[llvm] [CodeGen] Fix PreISelLowering not reporting changes (PR #102184)

Roger Ferrer Ibáñez via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 12:12:14 PDT 2024


rofirrim wrote:

> I changed that. 

Ah ok. Sorry, I missed that.

> What I think we would actually need are two return values: one indicating whether the intrinsic was removed and one indicating whether the code was changed at all.

I could not find any other user of `CachingVPExpander::expandVectorPredication` other than `PreISelLowering`. Looks like we do not have to tell apart the two cases and simply knowing something has changed would be enough.

https://github.com/llvm/llvm-project/pull/102184


More information about the llvm-commits mailing list