[llvm] [PAC][CodeGen][ELF][AArch64] Support signed GOT (PR #96164)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 12:08:30 PDT 2024


================
@@ -0,0 +1,82 @@
+; RUN: llc -mtriple=aarch64-linux-gnu -global-isel=0 -fast-isel=0         -verify-machineinstrs \
----------------
kovdan01 wrote:

> A filename that starts with `ptrauth-` might be better to group ptrauth tests together.

That makes sense (given that we already have some ptrauth-*.ll tests), thanks for suggestion. Renamed in bc3ae2a0a1a8689a9487b323d18f68b34f5d5dc9

> I am not sure the test should focus specifically on PIC. It's common to test both non-pic and pic in one test.

As for this PR, ptrauth-*.ll tests just duplicate corresponding non-pauth tests. I suppose that if we want to change how tests are organized, this should be done separately in order not to mix functional and refactoring changes.

https://github.com/llvm/llvm-project/pull/96164


More information about the llvm-commits mailing list