[llvm] [BOLT] Move ADRRelaxationPass (PR #101371)
Vladislav Khmelevsky via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 6 05:21:25 PDT 2024
yota9 wrote:
Well I think there is no documentation that would tell about pass order in BOLT. When creating new pass you need to consider yourself in which order it would be run. I've decided to run it on latter stage since there is no real difference where to put it and when remove ADR instructions. The pros to run it later is that it would also remove created adr instructions by bolt (if any). But we are not creating them and we don't have to create, any addresses on this stage should use adrp+add. And one of the cons found now is basically that nop instructions sometimes could be removed (also in my mind they really shouldn't due to #101964). Anyway there is no harm on moving this up as I said BOLT should avoid creating ADR instructions by it self and it doesn't really matter when we would replace them, so let's replace from the beginning.
https://github.com/llvm/llvm-project/pull/101371
More information about the llvm-commits
mailing list