[llvm] workflows/release-binaries: Give attestation artifacts a unique name (PR #102041)

via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 12:17:33 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

<details>
<summary>Changes</summary>

We need a different attestation for each supported architecture, so there artifacts all need to have a different name.

The upload step is run on a Linux runner, so no matter which architecture's binary is being uploaded the runner.os and runner.arch variables would always be 'Linux' and 'X64' and so we can't use them for naming the artifact.

---
Full diff: https://github.com/llvm/llvm-project/pull/102041.diff


1 Files Affected:

- (modified) .github/workflows/release-binaries.yml (+1-1) 


``````````diff
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 7cc8b7a1e56e8..fae04e19b246b 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -442,7 +442,7 @@ jobs:
     - name: Upload Build Provenance
       uses: actions/upload-artifact at 65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
       with:
-        name: ${{ runner.os }}-${{ runner.arch }}-release-binary-attestation
+        name: ${{ needs.prepare.outputs.release-binary-filename }}-attestation
         path: ${{ needs.prepare.outputs.release-binary-filename }}.jsonl
 
     - name: Upload Release

``````````

</details>


https://github.com/llvm/llvm-project/pull/102041


More information about the llvm-commits mailing list