[llvm] [GlobalIsel] Combine G_ADD and G_SUB with constants (PR #97771)

[Amara Emerson via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/97771 at github.com>


aemerson wrote:

I can sympathize with both of your sides. If we can guarantee that the constant is there why don't we just access it directly? What value does the `getIConstantVRegVal()` really bring there? Or we add a variant of that that just does what we want (which I thought we had already?).

Unchecked optionals has an off vibe, but ones that never fire also have a compile time impact.

https://github.com/llvm/llvm-project/pull/97771