[llvm] [PAC][CodeGen][ELF][AArch64] Support signed GOT (PR #96164)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 04:15:39 PDT 2024


================
@@ -30,6 +30,7 @@ const AArch64MCExpr *AArch64MCExpr::create(const MCExpr *Expr, VariantKind Kind,
 }
 
 StringRef AArch64MCExpr::getVariantKindName() const {
+  // clang-format off
----------------
kovdan01 wrote:

OK, let's allow clang-format to do its job after the PR is merged. I'd prefer not to include large styling changes on unrelated code in this commit and do them separately to distinguish new functionality and style changes. It looks like it would be a bit easier to just delete these `// clang-format off` comments after merging the PR rather than generating a diff, pre-committing it now, resolving merge conflicts...

The same applies to the comment in AArch64MCExpr.h below.

Please let me know if you have some concerns with this.

https://github.com/llvm/llvm-project/pull/96164


More information about the llvm-commits mailing list