[llvm] [SandboxIR][NFC] Fixes for LoadInst::create functions (PR #100955)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 28 21:46:51 PDT 2024
================
@@ -774,9 +773,9 @@ define void @foo(ptr %arg0, ptr %arg1) {
EXPECT_EQ(NewLd->getName(), "NewLd");
sandboxir::LoadInst *NewVLd =
- sandboxir::LoadInst::create(Vld->getType(), Arg1, Align(8),
- /*InsertBefore=*/Ret, Ctx,
- /*IsVolatile=*/true, "NewVLd");
+ sandboxir::LoadInst::create(VLd->getType(), Arg1, Align(8),
+ /*InsertBefore=*/Ret,
+ /*IsVolatile=*/true, Ctx, "NewVLd");
// Checking if create() was volatile
EXPECT_TRUE(NewVLd->isVolatile());
----------------
vporpo wrote:
So far we have tested `create(..., /*InsertBefore=*/)`, `create(..., /*InsertBefore=*/, /*IsVolatile=*/)` but we have not tested the ones with /*InsertAtEnd=*/. Could you add tests for these too?
https://github.com/llvm/llvm-project/pull/100955
More information about the llvm-commits
mailing list