[llvm] [SandboxIR] Added isVolatile args to existing LoadInst::create function (PR #100850)

Julius Alexandre via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 28 11:26:38 PDT 2024


================
@@ -764,11 +764,21 @@ define void @foo(ptr %arg0, ptr %arg1) {
   // Check create(InsertBefore)
   sandboxir::LoadInst *NewLd =
       sandboxir::LoadInst::create(Ld->getType(), Arg1, Align(8),
-                                  /*InsertBefore=*/Ret, Ctx, "NewLd");
+                                  /*InsertBefore=*/Ret, Ctx,
+                                  /*IsVolatile=*/false, "NewLd");
----------------
medievalghoul wrote:

Thank you for the suggestion, I'll start on the follow-up PR.

> This is OK for this PR

I was a bit confuse on this. Were you suggesting that this PR will get merge first before creating the follow-up NFC PR? If not, then I'll start on the follow-up.

https://github.com/llvm/llvm-project/pull/100850


More information about the llvm-commits mailing list