[lld] 74ef53a - [ELF] REGION_ALIAS: support quoted names

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 27 16:29:48 PDT 2024


Author: Fangrui Song
Date: 2024-07-27T16:29:43-07:00
New Revision: 74ef53a01a49e3818ac872e1cb7669c8017f0eb0

URL: https://github.com/llvm/llvm-project/commit/74ef53a01a49e3818ac872e1cb7669c8017f0eb0
DIFF: https://github.com/llvm/llvm-project/commit/74ef53a01a49e3818ac872e1cb7669c8017f0eb0.diff

LOG: [ELF] REGION_ALIAS: support quoted names

Added: 
    

Modified: 
    lld/ELF/ScriptParser.cpp
    lld/test/ELF/linkerscript/region-alias.s

Removed: 
    


################################################################################
diff  --git a/lld/ELF/ScriptParser.cpp b/lld/ELF/ScriptParser.cpp
index 7b01493c3bb66..b97efc44bae5a 100644
--- a/lld/ELF/ScriptParser.cpp
+++ b/lld/ELF/ScriptParser.cpp
@@ -549,7 +549,7 @@ void ScriptParser::readRegionAlias() {
   expect("(");
   StringRef alias = readName();
   expect(",");
-  StringRef name = next();
+  StringRef name = readName();
   expect(")");
 
   if (script->memoryRegions.count(alias))

diff  --git a/lld/test/ELF/linkerscript/region-alias.s b/lld/test/ELF/linkerscript/region-alias.s
index db716e180cc52..f6a6e1f1ddbd4 100644
--- a/lld/test/ELF/linkerscript/region-alias.s
+++ b/lld/test/ELF/linkerscript/region-alias.s
@@ -11,7 +11,7 @@
 # RUN: }" > %t.script
 
 ## .text to ROM, .data to RAM.
-# RUN: echo "REGION_ALIAS (\"ALIAS_TEXT\", ROM);" > %t.script.inc
+# RUN: echo 'REGION_ALIAS ("ALIAS_TEXT", "ROM");' > %t.script.inc
 # RUN: echo "REGION_ALIAS (\"ALIAS_DATA\", RAM);" >> %t.script.inc
 # RUN: ld.lld %t --script %t.script -o %t2
 # RUN: llvm-objdump --section-headers %t2 | FileCheck %s


        


More information about the llvm-commits mailing list