[llvm] [AsmPrinter] Don't EmitToStreamer instructions lowered by tblgenned code (PR #100803)
Sergei Barannikov via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 13:34:49 PDT 2024
================
@@ -160,8 +160,7 @@ class AArch64AsmPrinter : public AsmPrinter {
/// tblgen'erated driver function for lowering simple MI->MC
/// pseudo instructions.
- bool emitPseudoExpansionLowering(MCStreamer &OutStreamer,
----------------
s-barannikov wrote:
It no longer emits, so I had to rename it.
I chose that name because it effectively lowers MachineInstr to MCInst, much like non-generated versions,
e.g. `LowerARMMachineInstrToMCInst` or `RISCVAsmPrinter::lowerToMCInst` or `AMDGPUMCInstLower::lower`
(and `Impl` suffix so that it doesn't conflict with non-autogenerated versions, just in case). The set of arguments is also the same in most cases.
Would something of these be less confusing to you, or can you suggest better alternative without `emit` prefix?
- expandPseudoMachineInstrToMCInst
- expandPseudoInstrToMCInst
- expandPseudoMachineInstr
- expandPseudoInstr
- s/expand/lower one of these
https://github.com/llvm/llvm-project/pull/100803
More information about the llvm-commits
mailing list