[llvm] [SandboxIR] Added a new LoadInst::create() with a isVolatile arg (PR #100781)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 11:48:47 PDT 2024


================
@@ -743,6 +743,9 @@ class LoadInst final : public Instruction {
   static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
                           Instruction *InsertBefore, Context &Ctx,
                           const Twine &Name = "");
+  static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
+                          Instruction *InsertBefore, Context &Ctx,
+                          const Twine &Name = "", bool isVolatile);
----------------
vporpo wrote:

Makes sense. Something like `create(Type *Ty, Value *Ptr, MaybeAlign Align, Instruction *InsertBefore, Context &Ctx, bool IsVolatile = false, const Twine &Name = "")` ? I was suggesting using 4 functions because llvm::LoadInst is using separate constructors but I don't feel too strongly about it.

https://github.com/llvm/llvm-project/pull/100781


More information about the llvm-commits mailing list