[llvm] [SandboxIR] Added a new LoadInst::create() with a isVolatile arg (PR #100781)

Julius Alexandre via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 11:41:01 PDT 2024


================
@@ -743,6 +743,9 @@ class LoadInst final : public Instruction {
   static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
                           Instruction *InsertBefore, Context &Ctx,
                           const Twine &Name = "");
+  static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
+                          Instruction *InsertBefore, Context &Ctx,
+                          const Twine &Name = "", bool isVolatile);
----------------
medievalghoul wrote:

I think we can save some lines of code, do you think it'd be possible to just have 2 functions instead of 4. Where the isVolatile arg, has default value of `false` if there's no input? or should we stick to the original plan of having 4 functions?

https://github.com/llvm/llvm-project/pull/100781


More information about the llvm-commits mailing list