[llvm] [SandboxIR] Added a new LoadInst::create() with a isVolatile arg (PR #100781)

Julius Alexandre via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 10:52:59 PDT 2024


================
@@ -743,6 +743,9 @@ class LoadInst final : public Instruction {
   static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
                           Instruction *InsertBefore, Context &Ctx,
                           const Twine &Name = "");
+  static LoadInst *create(Type *Ty, Value *Ptr, MaybeAlign Align,
+                          Instruction *InsertBefore, Context &Ctx,
+                          const Twine &Name = "", bool isVolatile);
----------------
medievalghoul wrote:

> I would move the isVolatile flag before the Ctx argument.

will do

> Also we would need both versions of the create() function with the additional isVolatile argument + their bodies + tests :)

so for every function `create` function there needs to have a version where isVolatile is an argument?



https://github.com/llvm/llvm-project/pull/100781


More information about the llvm-commits mailing list