[llvm] [SandboxIR] Implement CallBase and CallInst (PR #100218)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 10:21:56 PDT 2024


================
@@ -1010,7 +1202,7 @@ class Context {
   size_t getNumValues() const { return LLVMValueToValueMap.size(); }
 };
 
-class Function : public sandboxir::Value {
+class Function : public Constant {
----------------
vporpo wrote:

In LLVM it inherits from GlobalObject which is a sub-class of GlobalValue, which is a sub-class of Constant. We don't have the intermediate Global* classes in Sandbox IR, so we inherit directly from Constant for now.

> ascii art above has Function twice now?
Good catch! I hadn't noticed :)

https://github.com/llvm/llvm-project/pull/100218


More information about the llvm-commits mailing list