[llvm] [DirectX] Update "dx.TypedBuffer" docs to include a "signed" bit (PR #100695)
Joshua Batista via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 09:48:18 PDT 2024
================
@@ -197,23 +200,23 @@ Examples:
.. code-block:: llvm
; RWBuffer<float4> Buf : register(u5, space3)
- %buf = call target("dx.TypedBuffer", float, 1, 0)
+ %buf = call target("dx.TypedBuffer", <4 x float>, 1, 0, 0)
@llvm.dx.handle.fromBinding.tdx.TypedBuffer_f32_1_0(
i32 3, i32 5, i32 1, i32 0, i1 false)
- ; RWBuffer<uint> Buf : register(u7, space2)
- %buf = call target("dx.TypedBuffer", i32, 1, 0)
+ ; RWBuffer<int> Buf : register(u7, space2)
+ %buf = call target("dx.TypedBuffer", i32, 1, 0, 1)
----------------
bob80905 wrote:
You say in this doc that `IsSigned` is an extra parameter, but that param is only present for `TypedBuffer`. Yet, I see a new parameter here.
Maybe you meant to write somewhere that RWBuffers are represented as TypedBuffers? Should that be made explicit? (Like you specified with ByteAddressBuffers above).
Otherwise, shouldn't we specify that RWBuffers also get an extra parameter, `IsSigned`?
https://github.com/llvm/llvm-project/pull/100695
More information about the llvm-commits
mailing list