[lld] [ELF] Support relocatable files using CREL (PR #98115)
Peter Smith via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 09:02:54 PDT 2024
================
@@ -592,6 +608,113 @@ static void finalizeShtGroup(OutputSection *os, InputSection *section) {
os->size = (1 + seen.size()) * sizeof(uint32_t);
}
+template <class uint>
+LLVM_ATTRIBUTE_ALWAYS_INLINE static void
+encodeOneCrel(raw_svector_ostream &os, uint &outOffset, uint32_t &outSymidx,
----------------
smithp35 wrote:
There quite a few parameters to the function. I'm wondering if it is worth keeping the output state that is passed by reference in a struct passed by reference. Might simplify the code and make it a bit more obvious that some parameter's are being updated.
https://github.com/llvm/llvm-project/pull/98115
More information about the llvm-commits
mailing list