[llvm] [llvm-objcopy] Add --change-section-address (PR #98664)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 02:14:26 PDT 2024


================
@@ -0,0 +1,211 @@
+# Tests behavior of --change-section-address option
----------------
jh7370 wrote:

```suggestion
## This test tests the behavior of the --change-section-address option.
```
You'll notice that most newer tests in the tools use `##` for proper comments. Comments should also be full sentences as a general rule, with trailing full stops. Applies to all the comments in the file.

Also, sorry, but this was a little more detailed than I'd imagined. The test is pretty self-documenting as to what yaml2obj does and what the initial object layout looks like (the YAML is simple and fairly clear), so I think you could just get rid of everything after the first line, just keeping the individual comments for the test cases to highlight what is significant about each line.

https://github.com/llvm/llvm-project/pull/98664


More information about the llvm-commits mailing list