[llvm] [llvm-objdump][BPF] infer local label names in BPF disassembly (PR #100550)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 00:16:45 PDT 2024
https://github.com/jh7370 approved this pull request.
Aside from one minor nit, I've got no issues with this, and am happy with @MaskRay's review.
> Will update and force push, if you don't mind force pushing.
You shouldn't need to force push, and I would actively discourage it, as it makes follow-up reviews harder (it's tricky to see what's changed since the previous review). Instead, you can use merge commits from `main`, if rebasing is needed, and fixup commits on your branch with the changes requested (these will also collapse into a single regular commit when you squash and merge).
Also worth noting that the final commit title and description is taken from the PR's title and description, so there's no need to amend the commit message for the already-committed commit in this PR. Instead, make sure to update the PR itself for @MaskRay's suggestion.
https://github.com/llvm/llvm-project/pull/100550
More information about the llvm-commits
mailing list