[llvm] [SandboxIR] Implement CallBase and CallInst (PR #100218)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 13:26:01 PDT 2024


================
@@ -435,7 +453,7 @@ class Constant : public sandboxir::User {
     return getUseOperandNoDefault(Use);
   }
 #ifndef NDEBUG
-  void verify() const final {
+  void verify() const override {
     assert(isa<llvm::Constant>(Val) && "Expected Constant!");
   }
   friend raw_ostream &operator<<(raw_ostream &OS,
----------------
vporpo wrote:

Currently `operator<<` calls `dump()` directly so it has to be guarded by `#ifndef NDEBUG`.
I would need to double check LLVM IR's behavior but I think you are right. Changing that for Sandbox IR would have to be a separate patch though.

https://github.com/llvm/llvm-project/pull/100218


More information about the llvm-commits mailing list