[llvm] [InstCombine] Enable saturated add canonicalization in more variants (PR #100008)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 12:52:11 PDT 2024


AtariDreams wrote:

> Please replace tests using something like uge C with ugt C-1 so the input is canonical. And then remove all the tests that become duplicates as a result.
> 
> 
> 
> Your alive2 proofs also include some preconditions -- some cases check that C!=0. But it does not look like your implementation contains those checks?

0 gets canonicalized out anyway so it won't be caught. That was just for the sake of alive2 

https://github.com/llvm/llvm-project/pull/100008


More information about the llvm-commits mailing list