[lld] [ELF] ScriptLexer: generate tokens lazily (PR #100493)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 12:07:57 PDT 2024


https://github.com/smithp35 commented:

Thanks for working on this. I've only got a few small suggestions, the remainder of the changes look fine and I was able to easily match them with the previous implementation.

One suggestion I'm in two minds about is whether `Buffer cur` would be better off named `curBuf` as `cur` on its own could mean anything. However it is almost always used as cur.s and `curBuf.s` isn't much better.


https://github.com/llvm/llvm-project/pull/100493


More information about the llvm-commits mailing list