[llvm] [InstCombine] Enable saturated add canonicalization in more variants (PR #100008)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 07:54:22 PDT 2024


https://github.com/nikic commented:

Please replace tests using something like uge C with ugt C-1 so the input is canonical. And then remove all the tests that become duplicates as a result.

Your alive2 proofs also include some preconditions -- some cases check that C!=0. But it does not look like your implementation contains those checks?

https://github.com/llvm/llvm-project/pull/100008


More information about the llvm-commits mailing list