[llvm] [StackFrameLayoutAnalysis] Support more SlotTypes (PR #100562)

Paul Kirth via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 07:11:30 PDT 2024


https://github.com/ilovepi approved this pull request.

I think this is mostly OK, but I wonder if we also just always need to sort by all the printed fields? So, offset, type, alignment and size? I think that may be necessary to avoid non determinism. If we’re doing that, then we probably don’t need to put VariableSize at then end. 

Can you add those other fields to the comparison?

https://github.com/llvm/llvm-project/pull/100562


More information about the llvm-commits mailing list