[llvm] [llvm-lit] Resolve env subcommand required error (PR #98414)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 07:10:50 PDT 2024


================
@@ -3,28 +3,32 @@
 #
 # NO-ARGS: BAR=2
 # NO-ARGS: FOO=1
+# NO-ARGS: BAZ=3
 
 # Set environment variables.
 # RUN: env FOO=2 BAR=1 | FileCheck -check-prefix=SET-VAL %s
 #
 # SET-VAL: BAR=1
 # SET-VAL: FOO=2
+# SET-VAL: BAZ=3
 
 # Unset environment variables.
 # RUN: env -u FOO -u BAR | FileCheck -check-prefix=UNSET-U %s
 #
-# UNSET_U-NOT: BAR
+# UNSET-U-NOT: BAR
 # UNSET-U-NOT: FOO
+# UNSET-U: BAZ=3
 
 # Mixed set and unset environment variables.
 # RUN: env -u FOO BAR=1 -u BAR FOO=2 | FileCheck -check-prefix=MIXED-SET-UNSET %s
 #
 # MIXED-SET-UNSET-NOT: BAR
 # MIXED-SET-UNSET: FOO=2
+# MIXED-SET-UNSET: BAZ=3
 
 # Mixed set and unset with additional variable.
 # RUN: env -u FOO BAR=1 -u BAR FOO=2 BAZ=3 | FileCheck -check-prefix=MIXED-SET-UNSET-ADD-3 %s
----------------
jh7370 wrote:

Since you've added `BAZ` to the set of default variables, this test case no longer covers what you meant to test, I believe. I think you need to change the reference to `BAZ` here to something else?

https://github.com/llvm/llvm-project/pull/98414


More information about the llvm-commits mailing list