[lld] [lld][ELF] remove `consumeLabel` in ScriptLexer (PR #99567)

Hongyu Chen via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 15:51:51 PDT 2024


================
@@ -1719,19 +1719,20 @@ ScriptParser::readSymbols() {
   while (!errorCount()) {
     if (consume("}"))
       break;
-    if (consumeLabel("local")) {
-      v = &locals;
-      continue;
-    }
-    if (consumeLabel("global")) {
-      v = &globals;
-      continue;
-    }
 
     if (consume("extern")) {
       SmallVector<SymbolVersion, 0> ext = readVersionExtern();
       v->insert(v->end(), ext.begin(), ext.end());
     } else {
+      if (consume("local:") || (consume("local") && consume(":"))) {
----------------
yugier wrote:

It makes a lot of sense now thank you very much! I just updated it again. 

https://github.com/llvm/llvm-project/pull/99567


More information about the llvm-commits mailing list