[llvm] 511823c - [MC] Make *ObjectWriter final

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2024-07-23T10:59:45-07:00
New Revision: 511823cbea2a6c4da61a2eb0f9a5aa20629ae51d

URL: https://github.com/llvm/llvm-project/commit/511823cbea2a6c4da61a2eb0f9a5aa20629ae51d
DIFF: https://github.com/llvm/llvm-project/commit/511823cbea2a6c4da61a2eb0f9a5aa20629ae51d.diff

LOG: [MC] Make *ObjectWriter final

to make it clear that target customization should be done by inheriting
from MCObjectTargetWriter subclasses instead of MCObjectWriter
subclasses.

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCELFObjectWriter.h
    llvm/include/llvm/MC/MCMachObjectWriter.h
    llvm/include/llvm/MC/MCWinCOFFObjectWriter.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCELFObjectWriter.h b/llvm/include/llvm/MC/MCELFObjectWriter.h
index 9b74cbc3d3a52..4952e0383b211 100644
--- a/llvm/include/llvm/MC/MCELFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCELFObjectWriter.h
@@ -154,7 +154,7 @@ class MCELFObjectTargetWriter : public MCObjectTargetWriter {
   }
 };
 
-class ELFObjectWriter : public MCObjectWriter {
+class ELFObjectWriter final : public MCObjectWriter {
   unsigned ELFHeaderEFlags = 0;
 
 public:

diff  --git a/llvm/include/llvm/MC/MCMachObjectWriter.h b/llvm/include/llvm/MC/MCMachObjectWriter.h
index 4386d84748271..4df9c92ae368d 100644
--- a/llvm/include/llvm/MC/MCMachObjectWriter.h
+++ b/llvm/include/llvm/MC/MCMachObjectWriter.h
@@ -83,7 +83,7 @@ class MCMachObjectTargetWriter : public MCObjectTargetWriter {
   /// @}
 };
 
-class MachObjectWriter : public MCObjectWriter {
+class MachObjectWriter final : public MCObjectWriter {
 public:
   struct DataRegionData {
     MachO::DataRegionType Kind;

diff  --git a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
index 49498871d741d..a4ede61e45099 100644
--- a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
@@ -45,7 +45,7 @@ class MCWinCOFFObjectTargetWriter : public MCObjectTargetWriter {
 
 class WinCOFFWriter;
 
-class WinCOFFObjectWriter : public MCObjectWriter {
+class WinCOFFObjectWriter final : public MCObjectWriter {
   friend class WinCOFFWriter;
 
   std::unique_ptr<MCWinCOFFObjectTargetWriter> TargetObjectWriter;