[llvm] [AArch64][BOLT] Ensure tentative code layout for cold BBs runs. (PR #96609)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 03:32:21 PDT 2024


================
@@ -354,9 +354,12 @@ uint64_t LongJmpPass::tentativeLayoutRelocMode(
   for (BinaryFunction *Func : SortedFunctions) {
     if (!BC.shouldEmit(*Func)) {
       HotAddresses[Func] = Func->getAddress();
-      continue;
+      // Don't perform any tentative address estimation of a function's cold
+      // layout if it won't be emitted, unless we are ignoring a large number of
----------------
yota9 wrote:

I think If we won't skip working on these functions we would end up with setting new address on 376 line which would be the wrong address for this function

https://github.com/llvm/llvm-project/pull/96609


More information about the llvm-commits mailing list