[llvm] [PseudoProbe] Add PseudoProbeDescUpdatePass (PR #99839)

Haohai Wen via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 22:52:10 PDT 2024


HaohaiWen wrote:

> > I think 2 is necessary and better to fix 1 since lost debug info is something always happened.
> 
> Why is this something that always happened? This is about an entire function missing debug info. Evidently, we haven't run into any such cases in any of our code base. Fixing #1 is handling the root cause, while fixing #2 is just hiding the underlying issue.
> 
> > Will you fix llvm-profgen issue?
> 
> We will get to that, feel free to send a patch too. But fixing root cause (#1) should be prioritized over this.

I had fixed several debug info missing issues. I believe there must be other places.
Anyway, adding a warning in llvm-profgen that hint user we have lost some debuginfo is more friendly than raising exception about GUID.

https://github.com/llvm/llvm-project/pull/99839


More information about the llvm-commits mailing list