[llvm] [SelectionDAG] Preserve volatile undef stores. (PR #99918)

Matt Davis via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 12:33:53 PDT 2024


================
@@ -255,7 +255,7 @@ define amdgpu_kernel void @marked_kernel_use_other_sgpr(ptr addrspace(1) %ptr) #
   %queue.load = load volatile i8, ptr addrspace(4) %queue.ptr
   %implicitarg.load = load volatile i8, ptr addrspace(4) %implicitarg.ptr
   %dispatch.load = load volatile i8, ptr addrspace(4) %dispatch.ptr
-  store volatile i64 %dispatch.id, ptr addrspace(1) %ptr
+  store i64 %dispatch.id, ptr addrspace(1) %ptr
----------------
enferex wrote:

By dropping the volatile we preserve the original FileCheck pattern.  I'm happy to restore the volatile and update the pattern match instead, that's probably the better choice given the intent of this patch.

https://github.com/llvm/llvm-project/pull/99918


More information about the llvm-commits mailing list