[llvm] [AMDGPU][MC] Improve error message for missing dim operand (PR #96588)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 10:52:54 PDT 2024


================
@@ -4006,6 +4007,29 @@ bool AMDGPUAsmParser::validateMIMGGatherDMask(const MCInst &Inst) {
   return DMask == 0x1 || DMask == 0x2 || DMask == 0x4 || DMask == 0x8;
 }
 
+bool AMDGPUAsmParser::validateMIMGDim(const MCInst &Inst,
+                                      const OperandVector &Operands) {
+  if (!isGFX10Plus())
----------------
arsenm wrote:

Right, you would need to add it. Or at least hide this in an alias that shows why the version matters 

https://github.com/llvm/llvm-project/pull/96588


More information about the llvm-commits mailing list