[llvm] [AArch64][BOLT] Ensure tentative code layout for cold BBs runs. (PR #96609)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 03:32:09 PDT 2024


================
@@ -382,6 +385,11 @@ uint64_t LongJmpPass::tentativeLayoutRelocMode(
     DotAddress += Func->estimateConstantIslandSize();
     ++CurrentIndex;
   }
+  if (!ColdLayoutDone) {
----------------
paschalis-mpeis wrote:

I see your point.

What I had in mind when writing the patch was to introduce a minimal change in the logic.
I'm not sure if running `tentativeLayoutRelocColdPart` at 388 would require any of the remaining code between 367-385 to run as well.

I would want some feedback from @yota9  on this, to see how can we refactor/simplify the pass he originally authored.

https://github.com/llvm/llvm-project/pull/96609


More information about the llvm-commits mailing list