[llvm] Reapply "[llvm/DWARF] Recursively resolve DW_AT_signature references"… (PR #99495)
Pavel Labath via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 22 00:49:30 PDT 2024
================
@@ -173,7 +169,8 @@ DWARFTypePrinter::appendUnqualifiedNameBefore(DWARFDie D,
case DW_TAG_base_type:
*/
default: {
- const char *NamePtr = dwarf::toString(D.find(DW_AT_name), nullptr);
+ const char *NamePtr =
+ dwarf::toString(D.findRecursively(DW_AT_name), nullptr);
----------------
labath wrote:
That would work, but I think that basically amounts to reverting all the changes in this file (as that's what the original code was doing). Is that what you're suggesting?
(The reason I changed this file was to demonstrate how one can write code to access the type mostly without caring about type units. It's not really required to make the main change (have recursive resolution look through type unit references), but it makes me wonder whether it is a good idea.)
https://github.com/llvm/llvm-project/pull/99495
More information about the llvm-commits
mailing list