[lld] [lld-macho] Fix erasing category names for ObjC categories (PR #99400)

Vincent Lee via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 17:46:14 PDT 2024


================
@@ -1303,12 +1303,16 @@ void ObjcCategoryMerger::eraseMergedCategories() {
         continue;
 
       eraseISec(catInfo.catBodyIsec);
-      // We can't erase 'catLayout.nameOffset' for Swift categories because the
-      // name will be referenced for generating relative offsets
-      // See usages of 'l_.str.11.SimpleClass' in objc-category-merging-swift.s
+
+      // We can't erase 'catLayout.nameOffset' for either Swift or ObjC
+      //   categories because the name will sometimes also be used for other
+      //   purposes.
+      // For Swift, see  usages of 'l_.str.11.SimpleClass' in
----------------
thevinster wrote:

```suggestion
      // For Swift, see usages of 'l_.str.11.SimpleClass' in
```

https://github.com/llvm/llvm-project/pull/99400


More information about the llvm-commits mailing list