[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 12:36:13 PDT 2024


================
@@ -14266,6 +14277,71 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef<StringRef> FeaturesStrs) {
   return Result;
 }
 
+Value *CodeGenFunction::EmitRISCVCpuSupports(ArrayRef<StringRef> FeaturesStrs,
+                                             unsigned &MaxGroupIDUsed) {
+
+  const unsigned FeatureBitSize = llvm::RISCV::RISCVFeatureBitSize;
----------------
preames wrote:

Please ignore my comment here about using weak symbols.  After reflecting further, I realized that having a link time dependence on the compiler support library is entirely reasonable - so long as that dependence is only present if the feature is actually used, as is done here.  

https://github.com/llvm/llvm-project/pull/85786


More information about the llvm-commits mailing list