[llvm] pr/amdgpu closed world (PR #66488)

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 10:13:13 PDT 2024


jdoerfert wrote:

> > @arsenm I rebased this, and moved the pass for now into the LTO pipeline. That breaks tests since they run the non-LTO one to check for the Attributor results. If I run it in the non-LTO pipeline, it only knows about closed world if you do thin-LTO, which is not ideal. Maybe there is a pipeline/extension point I missed? WDYT?
> 
> I'm confused, none of the codegen tests should be changing? LTO/Thin-LTO is upstream of all of the backend testing?

So, when I put it to the current location (FullLTO last callback), all opt and llc test failed because they don't run that. I did not update tests yet. The other FullLTO pass uses llvm-lto2 run to verify it runs properly. The pass is executed if I do a full compile with full or thin LTO.

https://github.com/llvm/llvm-project/pull/66488


More information about the llvm-commits mailing list