[llvm] [GlobalIsel] Combine G_ADD and G_SUB with constants (PR #97771)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 19 04:56:36 PDT 2024
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/97771 at github.com>
arsenm wrote:
> I can remove the comments. The alternative would be to pass the `G_CONSTANT` s as MachineInstr to the match function and then manually extract the immediate, but this is really ugly.
A null check that can never happen is misleading. Just don't check and let the assert in operator * do its job
https://github.com/llvm/llvm-project/pull/97771
More information about the llvm-commits
mailing list