[llvm] [GlobalIsel] Combine G_ADD and G_SUB with constants (PR #97771)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 03:49:50 PDT 2024


Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/97771 at github.com>


arsenm wrote:

> The comment is for documentation. I have to check optionals. I will never read from an optional before checking.

I say remove them, and/or introduce a cannot fail API 

https://github.com/llvm/llvm-project/pull/97771


More information about the llvm-commits mailing list