[llvm] [llvm-objcopy] Add --change-section-address (PR #98664)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 02:40:11 PDT 2024


================
@@ -745,6 +745,52 @@ static Error handleArgs(const CommonConfig &Config, const ELFConfig &ELFConfig,
     }
   }
 
+  if (!Config.ChangeSectionAddress.empty()) {
----------------
jh7370 wrote:

This condition and loop tree is WAY too nested, such that I can't realistically review it. Let's do some things to simplify it, perhaps breaking out some functions or using `std` or `llvm` algorithms for example.

https://github.com/llvm/llvm-project/pull/98664


More information about the llvm-commits mailing list