[llvm] [LV] Check isPredInst instead of isScalarWithPred in uniform analysis. (PR #98892)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 19 01:29:53 PDT 2024
================
@@ -3907,7 +3907,7 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
SetVector<Instruction *> Worklist;
// Add uniform instructions demanding lane 0 to the worklist. Instructions
- // that are scalar with predication must not be considered uniform after
+ // that are require predication must not be considered uniform after
// vectorization, because that would create an erroneous replicating region
// where only a single instance out of VF should be formed.
// TODO: optimize such seldom cases if found important, see PR40816.
----------------
fhahn wrote:
After reading through it (On GH https://github.com/llvm/llvm-project/issues/40162), I don't think so. AFAICT there is some potential improvements by creating interleave groups (or at least their runtime guards) later. Remove the TODO here
https://github.com/llvm/llvm-project/pull/98892
More information about the llvm-commits
mailing list