[llvm] pr/amdgpu closed world (PR #66488)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 00:18:44 PDT 2024


================
@@ -731,16 +731,11 @@ void AMDGPUTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB) {
         PM.addPass(createCGSCCToFunctionPassAdaptor(std::move(FPM)));
       });
 
-  // FIXME: Why is AMDGPUAttributor not in CGSCC?
-  PB.registerOptimizerLastEPCallback(
-      [this](ModulePassManager &MPM, OptimizationLevel Level) {
-        if (Level != OptimizationLevel::O0) {
-          MPM.addPass(AMDGPUAttributorPass(*this));
-        }
-      });
-
   PB.registerFullLinkTimeOptimizationLastEPCallback(
       [this](ModulePassManager &PM, OptimizationLevel Level) {
+        if (Level != OptimizationLevel::O0)
+          PM.addPass(
+              AMDGPUAttributorPass(*this, /*HasWholeProgramVisibility*/ true));
----------------
arsenm wrote:

```suggestion
              AMDGPUAttributorPass(*this, /*HasWholeProgramVisibility=*/ true));
```

https://github.com/llvm/llvm-project/pull/66488


More information about the llvm-commits mailing list