[llvm] [DebugInfo][InstrRef] Index DebugVariables and some DILocations (PR #99318)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `llvm` at step 7 "test-build-unified-tree-check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/2816

Here is the relevant piece of the build log for the reference:
```
Step 7 (test-build-unified-tree-check-llvm) failure: test (failure)
...
1.211 [2/10/670] Linking CXX executable unittests/Target/VE/VETests
1.223 [2/9/671] Linking CXX executable unittests/Target/WebAssembly/WebAssemblyTests
1.224 [2/8/672] Linking CXX executable unittests/Target/LoongArch/LoongArchTests
1.342 [2/7/673] Linking CXX executable unittests/Target/RISCV/RISCVTests
1.392 [2/6/674] Linking CXX executable unittests/Target/AArch64/AArch64Tests
1.468 [2/5/675] Linking CXX executable unittests/Target/ARM/ARMTests
1.476 [2/4/676] Linking CXX executable unittests/tools/llvm-mca/LLVMMCATests
1.868 [2/3/677] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
1.882 [2/2/678] Linking CXX executable unittests/Target/AMDGPU/AMDGPUTests
5.192 [2/1/679] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o
FAILED: unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/unittests/CodeGen -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/third-party/unittest/googletest/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/third-party/unittest/googlemock/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -MF unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o.d -o unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:224:35: error: no viable conversion from 'const SmallSet<llvm::DebugVariable, [...]>' to 'const SmallSet<LiveDebugValues::DebugVariableID, [...]>'
    LDV->buildVLocValueMap(DILoc, VarsWeCareAbout, AssignBlocks, Output,
                                  ^~~~~~~~~~~~~~~
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/llvm/ADT/SmallSet.h:135:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const SmallSet<llvm::DebugVariable, 4>' to 'const llvm::SmallSet<unsigned int, 4, std::less<unsigned int>> &' for 1st argument
class SmallSet {
      ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/llvm/ADT/SmallSet.h:135:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'const SmallSet<llvm::DebugVariable, 4>' to 'llvm::SmallSet<unsigned int, 4, std::less<unsigned int>> &&' for 1st argument
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1437:62: note: passing argument to parameter 'VarsWeCareAbout' here
                         const SmallSet<DebugVariableID, 4> &VarsWeCareAbout,
                                                             ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2649:19: error: no matching constructor for initialization of 'LiveDebugValues::VLocTracker'
  VLocs.resize(1, VLocTracker(Overlaps, EmptyExpr));
                  ^           ~~~~~~~~~~~~~~~~~~~
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class VLocTracker {
      ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
  VLocTracker(DebugVariableMap &DVMap, const OverlapMap &O,
  ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2661:17: error: no matching member function for call to 'insert'
  VLocs[0].Vars.insert({Var, DbgValue(LiveInRspID, EmptyProps)});
  ~~~~~~~~~~~~~~^~~~~~
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/llvm/ADT/MapVector.h:141:29: note: candidate function not viable: cannot convert initializer list argument to 'const std::pair<unsigned int, DbgValue>'
  std::pair<iterator, bool> insert(const std::pair<KeyT, ValueT> &KV) {
                            ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/llvm/ADT/MapVector.h:144:29: note: candidate function not viable: cannot convert initializer list argument to 'std::pair<unsigned int, DbgValue>'
  std::pair<iterator, bool> insert(std::pair<KeyT, ValueT> &&KV) {
                            ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2714:19: error: no matching constructor for initialization of 'LiveDebugValues::VLocTracker'
  VLocs.resize(4, VLocTracker(Overlaps, EmptyExpr));
                  ^           ~~~~~~~~~~~~~~~~~~~
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class VLocTracker {
      ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1042:7: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include/../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:1062:3: note: candidate constructor not viable: requires 3 arguments, but 2 were provided

```

https://github.com/llvm/llvm-project/pull/99318