[llvm] [workflows] Add a new workflow for checking commit access qualifications (PR #93301)
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 18 13:52:14 PDT 2024
tstellar wrote:
> * The Github library we're using doesn't support querying the GraphQL API? And there's no other well-supported libraries that do? It would be nice if we could do that instead.
>
I could not find one that works with GitHub.
> * It would be nice if we could unit test this. That would probably require mocking the whole thing though and require a lot of work. I'm not going to block on that because that would take quite a bit of effort, the results are going to be manually curated anyways, and something here is better than nothing, but it would be nice to have.
>
I think if the whole process were automated, then this would be more important, but the manual review means mistakes can get caught and have a smaller impact.
> * Typing annotations/doc strings - Would be nice to have, but not going to require them. The function names/comments make things pretty clear already.
I've added these.
https://github.com/llvm/llvm-project/pull/93301
More information about the llvm-commits
mailing list