[llvm] [DWARF] Emit line 0 source locations for BB padding nops (PR #99496)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff d097f430a172a5d798a39b416b1af84f4ec572e1 54d1dc24528f9f3e9b0b636ed0005f6b181c670d --extensions cpp,h -- llvm/include/llvm/CodeGen/DebugHandlerBase.h llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/CodeGen/DebugHandlerBase.h b/llvm/include/llvm/CodeGen/DebugHandlerBase.h
index 30e56269b5..85046c200f 100644
--- a/llvm/include/llvm/CodeGen/DebugHandlerBase.h
+++ b/llvm/include/llvm/CodeGen/DebugHandlerBase.h
@@ -137,7 +137,7 @@ public:
   void beginBasicBlockSection(const MachineBasicBlock &MBB);
   void endBasicBlockSection(const MachineBasicBlock &MBB);
 
-  virtual void beginCodeAlignment(const MachineBasicBlock& MBB) {}
+  virtual void beginCodeAlignment(const MachineBasicBlock &MBB) {}
 
   /// Return Label preceding the instruction.
   MCSymbol *getLabelBeforeInsn(const MachineInstr *MI);
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index 78cb5df4bd..038dbbb9ec 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -3966,8 +3966,7 @@ void AsmPrinter::emitBasicBlockStart(const MachineBasicBlock &MBB) {
 
   // Emit an alignment directive for this block, if needed.
   const Align Alignment = MBB.getAlignment();
-  if (Alignment != Align(1))
-  {
+  if (Alignment != Align(1)) {
     for (auto &Handler : DebugHandlers)
       Handler->beginCodeAlignment(MBB);
     emitAlignment(Alignment, nullptr, MBB.getMaxBytesForAlignment());
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
index 36e5370293..63cfd43035 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
@@ -3669,7 +3669,7 @@ bool DwarfDebug::alwaysUseRanges(const DwarfCompileUnit &CU) const {
   return false;
 }
 
-void DwarfDebug::beginCodeAlignment(const MachineBasicBlock& MBB) {
+void DwarfDebug::beginCodeAlignment(const MachineBasicBlock &MBB) {
   auto *SP = MBB.getParent()->getFunction().getSubprogram();
 
   bool NoDebug =
@@ -3679,8 +3679,8 @@ void DwarfDebug::beginCodeAlignment(const MachineBasicBlock& MBB) {
     return;
 
   auto PrevLoc = Asm->OutStreamer->getContext().getCurrentDwarfLoc();
-  Asm->OutStreamer->emitDwarfLocDirective(PrevLoc.getFileNum(), 0,
-                                                      0, 0, 0, 0, StringRef());
+  Asm->OutStreamer->emitDwarfLocDirective(PrevLoc.getFileNum(), 0, 0, 0, 0, 0,
+                                          StringRef());
   MCDwarfLineEntry::make(Asm->OutStreamer.get(),
                          Asm->OutStreamer->getCurrentSectionOnly());
 }
\ No newline at end of file
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
index eb474c0366..4847e9c8bd 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
@@ -728,7 +728,7 @@ public:
   void beginInstruction(const MachineInstr *MI) override;
 
   /// Process beginning of code alignment.
-  void beginCodeAlignment(const MachineBasicBlock& MBB) override;
+  void beginCodeAlignment(const MachineBasicBlock &MBB) override;
 
   /// Perform an MD5 checksum of \p Identifier and return the lower 64 bits.
   static uint64_t makeTypeSignature(StringRef Identifier);

``````````

</details>


https://github.com/llvm/llvm-project/pull/99496