[llvm] [DebugInfo][InstrRef] Index DebugVariables and some DILocations (PR #99318)

Thu Jul 18 07:08:56 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `llvm` at step 7 "test-build-unified-tree-check-llvm-unit".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/2502

Here is the relevant piece of the build log for the reference:
```
Step 7 (test-build-unified-tree-check-llvm-unit) failure: test (failure)
...
[678/689] Linking CXX executable unittests\Transforms\IPO\IPOTests.exe
[679/689] Linking CXX executable unittests\Passes\PassBuilderBindings\PassesBindingsTests.exe
[680/689] Linking CXX executable unittests\Target\TargetMachineCTests.exe
[681/689] Linking CXX executable unittests\Target\ARM\ARMTests.exe
[682/689] Linking CXX executable unittests\IR\IRTests.exe
[683/689] Linking CXX executable unittests\Transforms\Coroutines\CoroTests.exe
[684/689] Linking CXX executable unittests\Transforms\Instrumentation\InstrumentationTests.exe
[685/689] Linking CXX executable unittests\Transforms\Utils\UtilsTests.exe
[686/689] Linking CXX executable unittests\Transforms\Scalar\ScalarTests.exe
[687/689] Building CXX object unittests\CodeGen\CMakeFiles\CodeGenTests.dir\InstrRefLDVTest.cpp.obj
FAILED: unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\unittests\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googletest\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Founittests\CodeGen\CMakeFiles\CodeGenTests.dir\InstrRefLDVTest.cpp.obj /Fdunittests\CodeGen\CMakeFiles\CodeGenTests.dir\ /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(224): error C2664: 'void LiveDebugValues::InstrRefBasedLDV::buildVLocValueMap(const llvm::DILocation *,const llvm::SmallSet<LiveDebugValues::DebugVariableID,4,std::less<unsigned int>> &,llvm::SmallPtrSetImpl<PtrType> &,LiveDebugValues::InstrRefBasedLDV::LiveInsT &,LiveDebugValues::FuncValueTable &,LiveDebugValues::FuncValueTable &,llvm::SmallVectorImpl<LiveDebugValues::VLocTracker> &)': cannot convert argument 2 from 'const llvm::SmallSet<llvm::DebugVariable,4,std::less<T>>' to 'const llvm::SmallSet<LiveDebugValues::DebugVariableID,4,std::less<unsigned int>> &'
        with
        [
            PtrType=llvm::MachineBasicBlock *
        ]
        and
        [
            T=llvm::DebugVariable
        ]
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(224): note: Reason: cannot convert from 'const llvm::SmallSet<llvm::DebugVariable,4,std::less<T>>' to 'const llvm::SmallSet<LiveDebugValues::DebugVariableID,4,std::less<unsigned int>>'
        with
        [
            T=llvm::DebugVariable
        ]
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(224): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\../lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h(1436): note: see declaration of 'LiveDebugValues::InstrRefBasedLDV::buildVLocValueMap'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(224): note: while trying to match the argument list '(const llvm::DILocation *, const llvm::SmallSet<llvm::DebugVariable,4,std::less<T>>, llvm::SmallPtrSetImpl<PtrType>, LiveDebugValues::InstrRefBasedLDV::LiveInsT, LiveDebugValues::FuncValueTable, LiveDebugValues::FuncValueTable, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>)'
        with
        [
            T=llvm::DebugVariable
        ]
        and
        [
            PtrType=llvm::MachineBasicBlock *
        ]
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(2649): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'LiveDebugValues::VLocTracker'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(2649): note: 'LiveDebugValues::VLocTracker::VLocTracker': function does not take 2 arguments
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(2649): note: while trying to match the argument list '(LiveDebugValues::OverlapMap, llvm::DIExpression *)'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\CodeGen\InstrRefLDVTest.cpp(2661): error C2665: 'llvm::MapVector<LiveDebugValues::DebugVariableID,LiveDebugValues::DbgValue,llvm::DenseMap<unsigned int,unsigned int,llvm::DenseMapInfo<unsigned int,void>,llvm::detail::DenseMapPair<KeyT,ValueT>>,llvm::SmallVector<std::pair<KeyT,LiveDebugValues::DbgValue>,0>>::insert': no overloaded function could convert all the argument types
        with
        [
            KeyT=unsigned int,
            ValueT=unsigned int
        ]
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/ADT/MapVector.h(144): note: could be 'std::pair<std::pair<KeyT,ValueT> *,bool> llvm::MapVector<KeyT,ValueT,llvm::DenseMap<KeyT,unsigned int,llvm::DenseMapInfo<unsigned int,void>,llvm::detail::DenseMapPair<KeyT,unsigned int>>,llvm::SmallVector<std::pair<KeyT,ValueT>,0>>::insert(std::pair<KeyT,ValueT> &&)'
        with
        [

```

https://github.com/llvm/llvm-project/pull/99318