[llvm] [ADT] Make set_subtract more efficient when subtrahend is larger (NFC) (PR #98702)

Wed Jul 17 13:57:34 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-rocm-mi200` running on `mi200-buildbot` while building `llvm` at step 5 "build-check-mlir-build-only".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/177/builds/1789

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-check-mlir-build-only) failure: build (failure)
...
56.341 [1245/58/3363] Building CXX object tools/mlir/lib/Dialect/Linalg/Transforms/CMakeFiles/obj.MLIRLinalgTransforms.dir/WinogradConv2D.cpp.o
56.346 [1244/58/3364] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMAttrs.cpp.o
56.384 [1243/58/3365] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMTypes.cpp.o
56.385 [1242/58/3366] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMInterfaces.cpp.o
56.388 [1241/58/3367] Building CXX object tools/mlir/lib/Dialect/Linalg/Utils/CMakeFiles/obj.MLIRLinalgUtils.dir/Utils.cpp.o
56.407 [1240/58/3368] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMMemorySlot.cpp.o
56.423 [1239/58/3369] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/FunctionCallUtils.cpp.o
56.432 [1238/58/3370] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMTypeSyntax.cpp.o
56.435 [1237/58/3371] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMDialect.dir/IR/LLVMInlining.cpp.o
56.462 [1236/58/3372] Building CXX object tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o
FAILED: tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/tools/mlir/lib/Analysis -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/lib/Analysis -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/include -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/llvm/include -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/include -I/vol/worker/mi200-buildbot/mlir-rocm-mi200/build/tools/mlir/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o -MF tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o.d -o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o -c /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/lib/Analysis/Liveness.cpp
In file included from /vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/lib/Analysis/Liveness.cpp:19:
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/llvm/include/llvm/ADT/SetOperations.h:109:20: error: no viable conversion from 'typename SmallPtrSet<Value, 16>::iterator' (aka 'SmallPtrSetIterator<mlir::Value>') to 'mlir::Value'
  109 |           S1.erase(SI);
      |                    ^~
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/lib/Analysis/Liveness.cpp:80:11: note: in instantiation of function template specialization 'llvm::set_subtract<llvm::SmallPtrSet<mlir::Value, 16>, llvm::SmallPtrSet<mlir::Value, 16>>' requested here
   80 |     llvm::set_subtract(useValues, defValues);
      |           ^
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/include/mlir/IR/Value.h:96:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'typename SmallPtrSet<Value, 16>::iterator' (aka 'SmallPtrSetIterator<mlir::Value>') to 'const Value &' for 1st argument
   96 | class Value {
      |       ^~~~~
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/include/mlir/IR/Value.h:96:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'typename SmallPtrSet<Value, 16>::iterator' (aka 'SmallPtrSetIterator<mlir::Value>') to 'Value &&' for 1st argument
   96 | class Value {
      |       ^~~~~
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/mlir/include/mlir/IR/Value.h:98:13: note: candidate constructor not viable: no known conversion from 'typename SmallPtrSet<Value, 16>::iterator' (aka 'SmallPtrSetIterator<mlir::Value>') to 'detail::ValueImpl *' for 1st argument
   98 |   constexpr Value(detail::ValueImpl *impl = nullptr) : impl(impl) {}
      |             ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/vol/worker/mi200-buildbot/mlir-rocm-mi200/llvm-project/llvm/include/llvm/ADT/SmallPtrSet.h:361:22: note: passing argument to parameter 'Ptr' here
  361 |   bool erase(PtrType Ptr) {
      |                      ^
1 error generated.
56.467 [1236/57/3373] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRNVVMDialect.dir/IR/NVVMDialect.cpp.o
56.481 [1236/56/3374] Building CXX object tools/mlir/lib/Dialect/LLVMIR/Transforms/CMakeFiles/obj.MLIRLLVMIRTransforms.dir/DIExpressionRewriter.cpp.o
56.492 [1236/55/3375] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRROCDLDialect.dir/IR/ROCDLDialect.cpp.o
56.496 [1236/54/3376] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRVCIXDialect.dir/IR/VCIXDialect.cpp.o
56.504 [1236/53/3377] Building CXX object tools/mlir/test/lib/Conversion/OneToNTypeConversion/CMakeFiles/MLIRTestOneToNTypeConversionPass.dir/TestOneToNTypeConversionPass.cpp.o
57.178 [1236/52/3378] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/NewGVN.cpp.o
57.320 [1236/51/3379] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CmovConversion.cpp.o
57.536 [1236/50/3380] Building AMDGPUGenGlobalISel.inc...
57.590 [1236/49/3381] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/VectorUtils.cpp.o
57.842 [1236/48/3382] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/LoopInfo.cpp.o
57.844 [1236/47/3383] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/AsmParser.cpp.o
57.932 [1236/46/3384] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopStrengthReduce.cpp.o
58.181 [1236/45/3385] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FixupLEAs.cpp.o
58.199 [1236/44/3386] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/LoopAccessAnalysis.cpp.o
58.208 [1236/43/3387] Building CXX object tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/CFGLoopInfo.cpp.o
58.257 [1236/42/3388] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86PadShortFunction.cpp.o
58.307 [1236/41/3389] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86FixupBWInsts.cpp.o

```

https://github.com/llvm/llvm-project/pull/98702