[llvm] [BOLT][DWARF][NFC] Remove DWO ranges base (PR #99284)
Sayhaan Siddiqui via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 17 10:48:26 PDT 2024
https://github.com/sayhaan updated https://github.com/llvm/llvm-project/pull/99284
>From ae0a2b27c714619b7b29460bbed3a97f3a7b44c8 Mon Sep 17 00:00:00 2001
From: Sayhaan Siddiqui <sayhaan at meta.com>
Date: Wed, 17 Jul 2024 00:18:48 -0700
Subject: [PATCH 1/2] Remove dead code for DWORangesBase
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: https://phabricator.intern.facebook.com/D59867916
---
bolt/include/bolt/Rewrite/DWARFRewriter.h | 9 ---------
bolt/lib/Rewrite/DWARFRewriter.cpp | 1 -
2 files changed, 10 deletions(-)
diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h
index abd18b56113b6..b798c5b76fc28 100644
--- a/bolt/include/bolt/Rewrite/DWARFRewriter.h
+++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h
@@ -95,9 +95,6 @@ class DWARFRewriter {
std::mutex LocListDebugInfoPatchesMutex;
- /// Dwo id specific its RangesBase.
- std::unordered_map<uint64_t, uint64_t> DwoRangesBase;
-
std::unordered_map<DWARFUnit *, uint64_t> LineTablePatchMap;
std::unordered_map<const DWARFUnit *, uint64_t> TypeUnitRelocMap;
@@ -191,12 +188,6 @@ class DWARFRewriter {
/// Update stmt_list for CUs based on the new .debug_line \p Layout.
void updateLineTableOffsets(const MCAssembler &Asm);
- uint64_t getDwoRangesBase(uint64_t DWOId) { return DwoRangesBase[DWOId]; }
-
- void setDwoRangesBase(uint64_t DWOId, uint64_t RangesBase) {
- DwoRangesBase[DWOId] = RangesBase;
- }
-
using OverriddenSectionsMap = std::unordered_map<DWARFSectionKind, StringRef>;
/// Output .dwo files.
void writeDWOFiles(DWARFUnit &, const OverriddenSectionsMap &,
diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp
index 042c39a574561..4ba6344925856 100644
--- a/bolt/lib/Rewrite/DWARFRewriter.cpp
+++ b/bolt/lib/Rewrite/DWARFRewriter.cpp
@@ -719,7 +719,6 @@ void DWARFRewriter::updateDebugInfo() {
} else {
TempRangesSectionWriter = LegacyRangesWritersByCU[*DWOId].get();
RangesBase = RangesSectionWriter->getSectionOffset();
- setDwoRangesBase(*DWOId, *RangesBase);
}
updateUnitDebugInfo(*(*SplitCU), DWODIEBuilder, DebugLocDWoWriter,
>From 3fbb5f5cb5c57a0a6f8bef43825163f91b4d20fe Mon Sep 17 00:00:00 2001
From: Sayhaan Siddiqui <sayhaan at meta.com>
Date: Wed, 17 Jul 2024 10:46:46 -0700
Subject: [PATCH 2/2] Rerun CI
More information about the llvm-commits
mailing list