[llvm] [SROA] Fix debug locations for variables with non-zero offsets (PR #97750)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 07:33:26 PDT 2024


================
@@ -5110,57 +5288,79 @@ bool SROA::splitAlloca(AllocaInst &AI, AllocaSlices &AS) {
   NumAllocaPartitions += NumPartitions;
   MaxPartitionsPerAlloca.updateMax(NumPartitions);
 
-  // Migrate debug information from the old alloca to the new alloca(s)
-  // and the individual partitions.
----------------
jmorse wrote:

To my mind a reader going through the function top-to-bottom will want to know what this lambda is doing, hence it's good to have a comment where it's defined. This is a style thing, YMMV.

https://github.com/llvm/llvm-project/pull/97750


More information about the llvm-commits mailing list