[llvm] [VP] Refactor VectorBuilder to avoid layering violation. NFC (PR #99276)
Fraser Cormack via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 17 02:09:57 PDT 2024
================
@@ -569,6 +569,9 @@ class VPIntrinsic : public IntrinsicInst {
/// The llvm.vp.* intrinsics for this instruction Opcode
static Intrinsic::ID getForOpcode(unsigned OC);
+ /// The llvm.vp.reduce.* intrinsics for this intrinsic.
----------------
frasercrmck wrote:
`intrinsic for this intrinsic`.
Also, doesn't this function now return more than just reduction intrinsics? It handles all intrinsic->vp.intrinsic mappings we have.
Should we unit test this function?
https://github.com/llvm/llvm-project/pull/99276
More information about the llvm-commits
mailing list