[llvm] [workflows] Add a new workflow for checking commit access qualifications (PR #93301)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 23:53:51 PDT 2024


https://github.com/boomanaiden154 commented:

Mostly looks good to me, a couple nits.

A couple high level comments
* The Github library we're using doesn't support querying the GraphQL API? And there's no other well-supported libraries that do? It would be nice if we could do that instead.
* It would be nice if we could unit test this. That would probably require mocking the whole thing though and require a lot of work. I'm not going to block on that because that would take quite a bit of effort, the results are going to be manually curated anyways, and something here is better than nothing, but it would be nice to have.
* Typing annotations/doc strings - Would be nice to have, but not going to require them. The function names/comments make things pretty clear already.

One main question:
* Do you have numbers on how many API requests this uses? At a quick glance I would expect it to use quite a bit. If it's under the `RELEASE_TASKS_USER_TOKEN`, it might be fine though?

https://github.com/llvm/llvm-project/pull/93301


More information about the llvm-commits mailing list