[compiler-rt] [scudo] Add static vector functionality. (PR #98986)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 20:13:33 PDT 2024


ChiaHungDuan wrote:

> Originally, I though we might want to allow a zero length capacity. But thinking about it a bit more, I don't think we should since that would likely be a bug. If we ever decide to allow it, we can change the static assert.
> 
> Chia-hung, make sure the usage of bytes instead of items is okay with you.

Left a comment about the default size.

About the zero length, I told Jushua that he can either do default to 1 if it's 0 (like what llvm::SmallVector does) or static_assert that. Based on your suggestion, I think it's better to just disallow it.

https://github.com/llvm/llvm-project/pull/98986


More information about the llvm-commits mailing list